Modelling and drafting practice

Hi Experts

The attached model and drawing is a universal joint cross which I made in solidworks as a part of my learning process. 

Though the modelling in done using basic tools, I would like to know "Have I given a machinist everything they need to make this part". I beleive some of the experts in this forum woud be able to chek this drawing and make some comments on how good it is and what should I follw to make a better drawing.

​​​​​​​